summary refs log tree commit diff stats
path: root/hw/virtio/vhost-user-gpio.c
diff options
context:
space:
mode:
authorLi Feng <fengli@smartx.com>2023-11-23 13:54:11 +0800
committerMichael S. Tsirkin <mst@redhat.com>2023-12-02 15:56:49 -0500
commit298d4f892e745cfb8a33b5ed2feaaab271f6e50c (patch)
tree751f4bff111a6cc8223ddd64f9d2e87dbe74baac /hw/virtio/vhost-user-gpio.c
parent2d37fe9e5e61b04bddbed00dbb7436e61a01c115 (diff)
downloadfocaccia-qemu-298d4f892e745cfb8a33b5ed2feaaab271f6e50c.tar.gz
focaccia-qemu-298d4f892e745cfb8a33b5ed2feaaab271f6e50c.zip
vhost-user: fix the reconnect error
If the error occurs in vhost_dev_init, the value of s->connected is set to true
in advance, and there is no chance to enter this function execution again
in the future.

Signed-off-by: Li Feng <fengli@smartx.com>
Message-Id: <20231123055431.217792-2-fengli@smartx.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/virtio/vhost-user-gpio.c')
-rw-r--r--hw/virtio/vhost-user-gpio.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/virtio/vhost-user-gpio.c b/hw/virtio/vhost-user-gpio.c
index aff2d7eff6..a83437a5da 100644
--- a/hw/virtio/vhost-user-gpio.c
+++ b/hw/virtio/vhost-user-gpio.c
@@ -229,7 +229,6 @@ static int vu_gpio_connect(DeviceState *dev, Error **errp)
     if (gpio->connected) {
         return 0;
     }
-    gpio->connected = true;
 
     vhost_dev_set_config_notifier(vhost_dev, &gpio_ops);
     gpio->vhost_user.supports_config = true;
@@ -243,6 +242,8 @@ static int vu_gpio_connect(DeviceState *dev, Error **errp)
         return ret;
     }
 
+    gpio->connected = true;
+
     /* restore vhost state */
     if (virtio_device_started(vdev, vdev->status)) {
         vu_gpio_start(vdev);