diff options
| author | Stefano Garzarella <sgarzare@redhat.com> | 2020-03-31 09:59:10 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2020-03-31 10:54:28 -0400 |
| commit | e82cdba3945340f524ba153170d52800dbd55ca4 (patch) | |
| tree | 64c0ef71524700c703047ae6972e9e6d46aad341 /hw/virtio/vhost-vsock.c | |
| parent | 17e89077b7e3bc1d96540e21ddc7451c3e077049 (diff) | |
| download | focaccia-qemu-e82cdba3945340f524ba153170d52800dbd55ca4.tar.gz focaccia-qemu-e82cdba3945340f524ba153170d52800dbd55ca4.zip | |
vhost-vsock: fix double close() in the realize() error path
vhost_dev_cleanup() closes the vhostfd parameter passed to vhost_dev_init(), so this patch avoids closing it twice in the vhost_vsock_device_realize() error path. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20200331075910.42529-1-sgarzare@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/virtio/vhost-vsock.c')
| -rw-r--r-- | hw/virtio/vhost-vsock.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c index 9f9093e196..09b6b07f94 100644 --- a/hw/virtio/vhost-vsock.c +++ b/hw/virtio/vhost-vsock.c @@ -364,12 +364,16 @@ static void vhost_vsock_device_realize(DeviceState *dev, Error **errp) err_vhost_dev: vhost_dev_cleanup(&vsock->vhost_dev); + /* vhost_dev_cleanup() closes the vhostfd passed to vhost_dev_init() */ + vhostfd = -1; err_virtio: virtio_delete_queue(vsock->recv_vq); virtio_delete_queue(vsock->trans_vq); virtio_delete_queue(vsock->event_vq); virtio_cleanup(vdev); - close(vhostfd); + if (vhostfd >= 0) { + close(vhostfd); + } return; } |