diff options
| author | Wang Liang <wangliangzz@inspur.com> | 2021-03-16 22:41:45 -0400 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2021-03-22 10:17:53 -0400 |
| commit | d2adda34a9989404a4fc86cb4127a3ea103a7938 (patch) | |
| tree | 9412a4a05b127c8c5623feff6306ada25c0804b6 /hw/virtio/virtio-pmem.c | |
| parent | db8a3772e300c1a656331a92da0785d81667dc81 (diff) | |
| download | focaccia-qemu-d2adda34a9989404a4fc86cb4127a3ea103a7938.tar.gz focaccia-qemu-d2adda34a9989404a4fc86cb4127a3ea103a7938.zip | |
virtio-pmem: fix virtio_pmem_resp assign problem
ret in virtio_pmem_resp is a uint32_t variable, which should be assigned using virtio_stl_p. The kernel side driver does not guarantee virtio_pmem_resp to be initialized to zero in advance, So sometimes the flush operation will fail. Signed-off-by: Wang Liang <wangliangzz@inspur.com> Message-Id: <20210317024145.271212-1-wangliangzz@126.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/virtio/virtio-pmem.c')
| -rw-r--r-- | hw/virtio/virtio-pmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index a3e0688a89..d1aeb90a31 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -47,7 +47,7 @@ static int worker_cb(void *opaque) err = 1; } - virtio_stw_p(req_data->vdev, &req_data->resp.ret, err); + virtio_stl_p(req_data->vdev, &req_data->resp.ret, err); return 0; } |