diff options
| author | Anthony PERARD <anthony.perard@citrix.com> | 2023-07-04 18:18:19 +0100 |
|---|---|---|
| committer | Anthony PERARD <anthony.perard@citrix.com> | 2023-08-01 10:22:33 +0100 |
| commit | aa36243514a777f76c8b8a19b1f8a71f27ec6c78 (patch) | |
| tree | 683f4b72606fcdd253afc37405293802c80c67e1 /hw/xen/xen-hvm-common.c | |
| parent | ace33a0e5a5191f79899397adb766dda7208cb93 (diff) | |
| download | focaccia-qemu-aa36243514a777f76c8b8a19b1f8a71f27ec6c78.tar.gz focaccia-qemu-aa36243514a777f76c8b8a19b1f8a71f27ec6c78.zip | |
xen-block: Avoid leaks on new error path
Commit 189829399070 ("xen-block: Use specific blockdev driver")
introduced a new error path, without taking care of allocated
resources.
So only allocate the qdicts after the error check, and free both
`filename` and `driver` when we are about to return and thus taking
care of both success and error path.
Coverity only spotted the leak of qdicts (*_layer variables).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: Coverity CID 1508722, 1398649
Fixes: 189829399070 ("xen-block: Use specific blockdev driver")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230704171819.42564-1-anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Diffstat (limited to 'hw/xen/xen-hvm-common.c')
0 files changed, 0 insertions, 0 deletions