diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-04-22 15:31:49 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-05-04 14:43:24 +0200 |
| commit | 2c8ed55f0f615ea825cb30e80e74a07d6945bcf9 (patch) | |
| tree | c27a477a118a94c489d2b10c698a4e02aca24dcf /hw | |
| parent | 22c9336d3a82d1469796b7421cb5bd5f9bfd9748 (diff) | |
| download | focaccia-qemu-2c8ed55f0f615ea825cb30e80e74a07d6945bcf9.tar.gz focaccia-qemu-2c8ed55f0f615ea825cb30e80e74a07d6945bcf9.zip | |
hw/isa/i82378: Remove dead assignment
Rename the unique variable assigned as 'pit' which better
represents what it holds, to fix a warning reported by the
Clang static code analyzer:
CC hw/isa/i82378.o
hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read
isa = isa_create_simple(isabus, "i82374");
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200422133152.16770-7-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/isa/i82378.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index dcb6b479ea..d9e6c7fa00 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -67,7 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp) I82378State *s = I82378(dev); uint8_t *pci_conf; ISABus *isabus; - ISADevice *isa; + ISADevice *pit; pci_conf = pci->config; pci_set_word(pci_conf + PCI_COMMAND, @@ -99,13 +99,13 @@ static void i82378_realize(PCIDevice *pci, Error **errp) isa_bus_irqs(isabus, s->i8259); /* 1 82C54 (pit) */ - isa = i8254_pit_init(isabus, 0x40, 0, NULL); + pit = i8254_pit_init(isabus, 0x40, 0, NULL); /* speaker */ - pcspk_init(isabus, isa); + pcspk_init(isabus, pit); /* 2 82C37 (dma) */ - isa = isa_create_simple(isabus, "i82374"); + isa_create_simple(isabus, "i82374"); } static void i82378_init(Object *obj) |