summary refs log tree commit diff stats
path: root/hw
diff options
context:
space:
mode:
authorGavin Shan <gshan@redhat.com>2023-07-21 20:44:37 +1000
committerPeter Maydell <peter.maydell@linaro.org>2024-01-12 14:02:23 +0000
commit393d5c5bc717b18cd361b4a1ffbfe2a18b29a03b (patch)
treebe374fd1d87f1edca13923f38a3cdbbb41cfe45d /hw
parent3fab43d2f638b98765b0f8ef033ec93e3ea6b809 (diff)
downloadfocaccia-qemu-393d5c5bc717b18cd361b4a1ffbfe2a18b29a03b.tar.gz
focaccia-qemu-393d5c5bc717b18cd361b4a1ffbfe2a18b29a03b.zip
numa: Skip invalidation of cluster and NUMA node boundary for qtest
There are warning messages printed from tests/qtest/numa-test.c,
to complain the CPU cluster and NUMA node boundary is broken. Since
the broken boundary is expected, we don't want to see the warning
messages.

  # cd /home/gavin/sandbox/qemu.main/build
  # MALLOC_PERTURB_=255 QTEST_QEMU_BINARY=./qemu-system-aarch64           \
    G_TEST_DBUS_DAEMON=../tests/dbus-vmstate-daemon.sh                    \
    QTEST_QEMU_IMG=./qemu-img                                             \
    QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon \
    tests/qtest/numa-test --tap -k
      :
    qemu-system-aarch64: warning: CPU-0 and CPU-4 in socket-0-cluster-0   \
    have been associated with node-0 and node-1 respectively.             \
    It can cause OSes like Linux to misbehave
      :

Skip the invalidation of CPU cluster and NUMA node boundary when
qtest is enabled, to avoid the warning messages.

Fixes: a494fdb715 ("numa: Validate cluster and NUMA node boundary if required")
Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw')
-rw-r--r--hw/core/machine.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/core/machine.c b/hw/core/machine.c
index fc239101f9..fb5afdcae4 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1312,7 +1312,7 @@ static void validate_cpu_cluster_to_numa_boundary(MachineState *ms)
     const CPUArchId *cpus = possible_cpus->cpus;
     int i, j;
 
-    if (state->num_nodes <= 1 || possible_cpus->len <= 1) {
+    if (qtest_enabled() || state->num_nodes <= 1 || possible_cpus->len <= 1) {
         return;
     }