summary refs log tree commit diff stats
path: root/include/chardev
diff options
context:
space:
mode:
authorAnton Nefedov <anton.nefedov@virtuozzo.com>2017-07-25 13:04:41 +0300
committerPaolo Bonzini <pbonzini@redhat.com>2017-08-01 17:27:33 +0200
commit0ec846bface0f9733ca61ba18e3d4b72bfd9f8ca (patch)
treeba0be0c50679eccff36b1668ec7c8d001ba7e1c6 /include/chardev
parent4db0db1fa6b653970148f6ff7a24bede1d52ef9d (diff)
downloadfocaccia-qemu-0ec846bface0f9733ca61ba18e3d4b72bfd9f8ca.tar.gz
focaccia-qemu-0ec846bface0f9733ca61ba18e3d4b72bfd9f8ca.zip
char: don't exit on hmp 'chardev-add help'
qemu_chr_new_from_opts() is used from both vl.c and hmp,
and it is quite confusing to see qemu suddenly exit after receiving a help
option in hmp.

Do exit(0) from vl.c instead.

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Message-Id: <1500977081-120929-1-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/chardev')
-rw-r--r--include/chardev/char.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/include/chardev/char.h b/include/chardev/char.h
index 1604ea9143..66dde4637e 100644
--- a/include/chardev/char.h
+++ b/include/chardev/char.h
@@ -65,7 +65,9 @@ struct Chardev {
  *
  * @opts see qemu-config.c for a list of valid options
  *
- * Returns: a new character backend
+ * Returns: on success: a new character backend
+ *          otherwise:  NULL; @errp specifies the error
+ *                            or left untouched in case of help option
  */
 Chardev *qemu_chr_new_from_opts(QemuOpts *opts,
                                 Error **errp);