summary refs log tree commit diff stats
path: root/include/exec/cpu-common.h
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2021-09-03 11:59:27 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2024-05-08 19:11:34 +0200
commitf9cc8cfdf346cadc92db8fce32c8b5d7f1095163 (patch)
tree55b4968bfbad666ace16fa138880a7c9a7a21039 /include/exec/cpu-common.h
parent4e66a08546a2588a4667766a1edab9caccf24ce3 (diff)
downloadfocaccia-qemu-f9cc8cfdf346cadc92db8fce32c8b5d7f1095163.tar.gz
focaccia-qemu-f9cc8cfdf346cadc92db8fce32c8b5d7f1095163.zip
block/qcow2-bitmap: Replace g_memdup() by g_memdup2()
Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538

  The old API took the size of the memory to duplicate as a guint,
  whereas most memory functions take memory sizes as a gsize. This
  made it easy to accidentally pass a gsize to g_memdup(). For large
  values, that would lead to a silent truncation of the size from 64
  to 32 bits, and result in a heap area being returned which is
  significantly smaller than what the caller expects. This can likely
  be exploited in various modules to cause a heap buffer overflow.

Replace g_memdup() by the safer g_memdup2() wrapper.

Trivially safe because the argument was directly from sizeof.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210903174510.751630-6-philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'include/exec/cpu-common.h')
0 files changed, 0 insertions, 0 deletions