diff options
| author | Bernhard Beschow <shentey@gmail.com> | 2023-09-08 10:42:28 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2023-10-04 18:15:05 -0400 |
| commit | 9a4fedcf12ae388722fa5430df92d0f41e3ba9be (patch) | |
| tree | 01eb4c5f10ee06ecbc2025bfc458271b70e46c01 /include/hw/acpi/acpi_dev_interface.h | |
| parent | f4a06e5921ec93bbb8baeca59f662672077535c3 (diff) | |
| download | focaccia-qemu-9a4fedcf12ae388722fa5430df92d0f41e3ba9be.tar.gz focaccia-qemu-9a4fedcf12ae388722fa5430df92d0f41e3ba9be.zip | |
hw/acpi/cpu: Have build_cpus_aml() take a build_madt_cpu_fn callback
build_cpus_aml() is architecture independent but needs to create architecture- specific CPU AML. So far this was achieved by using a virtual method from TYPE_ACPI_DEVICE_IF. However, build_cpus_aml() would resolve this interface from global (!) state. This makes it quite incomprehensible where this interface comes from (TYPE_PIIX4_PM?, TYPE_ICH9_LPC_DEVICE?, TYPE_ACPI_GED_X86?) an can lead to crashes when the generic code is ported to new architectures. So far, build_cpus_aml() is only called in architecture-specific code -- and only in x86. We can therefore simply pass pc_madt_cpu_entry() as callback to build_cpus_aml(). This is the same callback that would be used through TYPE_ACPI_DEVICE_IF. Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230908084234.17642-3-shentey@gmail.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/acpi/acpi_dev_interface.h')
0 files changed, 0 insertions, 0 deletions