summary refs log tree commit diff stats
path: root/include/hw/acpi/pc-hotplug.h
diff options
context:
space:
mode:
authorIgor Mammedov <imammedo@redhat.com>2016-12-06 00:32:28 +0100
committerMichael S. Tsirkin <mst@redhat.com>2017-01-10 07:03:24 +0200
commit80db0e7822962554c91bef05d784c898e8ab1c3c (patch)
treec62e40df1b60281f063d59a741af40c5e8f2836c /include/hw/acpi/pc-hotplug.h
parentc9c085458060db9a63fa05c51e33c75e8390b2dc (diff)
downloadfocaccia-qemu-80db0e7822962554c91bef05d784c898e8ab1c3c.tar.gz
focaccia-qemu-80db0e7822962554c91bef05d784c898e8ab1c3c.zip
memhp: don't generate memory hotplug AML if it's not enabled/supported
That reduces DSDT by 910 bytes when memory hotplug
isn't enabled.

While doing so drop intermediate variables/arguments
passing around ACPI_MEMORY_HOTPLUG_IO_LEN and making
it local to memory_hotplug.c, hardcoding it there as
it can't change.

Also don't pass around ACPI_MEMORY_HOTPLUG_BASE through
intermediate variables/arguments where it's not needed.
Instead initialize in module static variable when MMIO
region is mapped and use that within memory_hotplug.c
whenever it's required.
That way MMIO base specified only at one place and AML
with MMIO would always use the same value.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Diffstat (limited to 'include/hw/acpi/pc-hotplug.h')
-rw-r--r--include/hw/acpi/pc-hotplug.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/hw/acpi/pc-hotplug.h b/include/hw/acpi/pc-hotplug.h
index a4f513d710..31bc9191c3 100644
--- a/include/hw/acpi/pc-hotplug.h
+++ b/include/hw/acpi/pc-hotplug.h
@@ -29,7 +29,6 @@
 #define PIIX4_CPU_HOTPLUG_IO_BASE 0xaf00
 #define CPU_HOTPLUG_RESOURCE_DEVICE PRES
 
-#define ACPI_MEMORY_HOTPLUG_IO_LEN 24
 #define ACPI_MEMORY_HOTPLUG_BASE 0x0a00
 
 #endif