summary refs log tree commit diff stats
path: root/include/hw/core/tcg-cpu-ops.h
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2021-07-29 10:45:10 -1000
committerRichard Henderson <richard.henderson@linaro.org>2021-09-21 19:36:44 -0700
commitfa947a667fceab02f9f85fc99f54aebcc9ae6b51 (patch)
treed739930621271a7991592e3742b63db15f812a9d /include/hw/core/tcg-cpu-ops.h
parent220b2da7f34c29412db0dc0182e36fce67c8a9e4 (diff)
downloadfocaccia-qemu-fa947a667fceab02f9f85fc99f54aebcc9ae6b51.tar.gz
focaccia-qemu-fa947a667fceab02f9f85fc99f54aebcc9ae6b51.zip
hw/core: Make do_unaligned_access noreturn
While we may have had some thought of allowing system-mode
to return from this hook, we have no guests that require this.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'include/hw/core/tcg-cpu-ops.h')
-rw-r--r--include/hw/core/tcg-cpu-ops.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
index 55123cb4d2..6cbe17f2e6 100644
--- a/include/hw/core/tcg-cpu-ops.h
+++ b/include/hw/core/tcg-cpu-ops.h
@@ -78,10 +78,11 @@ struct TCGCPUOps {
                                   MemTxResult response, uintptr_t retaddr);
     /**
      * @do_unaligned_access: Callback for unaligned access handling
+     * The callback must exit via raising an exception.
      */
     void (*do_unaligned_access)(CPUState *cpu, vaddr addr,
                                 MMUAccessType access_type,
-                                int mmu_idx, uintptr_t retaddr);
+                                int mmu_idx, uintptr_t retaddr) QEMU_NORETURN;
 
     /**
      * @adjust_watchpoint_address: hack for cpu_check_watchpoint used by ARM