diff options
| author | Greg Kurz <groug@kaod.org> | 2017-06-08 15:42:50 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2017-06-09 12:12:34 +1000 |
| commit | 100f738850639a108d6767316ce4dcc1d1ea4ae4 (patch) | |
| tree | 93f9e62c7818d3f2437ae2b9c1d7dd28407d8aa8 /include/hw/ppc | |
| parent | ad265631c0a0addc06ec3c4f133e746f4dcc872a (diff) | |
| download | focaccia-qemu-100f738850639a108d6767316ce4dcc1d1ea4ae4.tar.gz focaccia-qemu-100f738850639a108d6767316ce4dcc1d1ea4ae4.zip | |
xics: pass appropriate types to realize() handlers.
It makes more sense to pass an IPCState * to handlers of ICPStateClass instead of a DeviceState *, if only to benefit from compile time type checking. The same goes with ICSStateClass. While here, we also change the declaration of ICPStateClass in xics.h for consistency. Signed-off-by: Greg Kurz <groug@kaod.org> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'include/hw/ppc')
| -rw-r--r-- | include/hw/ppc/xics.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 31145326eb..797df82fef 100644 --- a/include/hw/ppc/xics.h +++ b/include/hw/ppc/xics.h @@ -65,9 +65,9 @@ typedef struct XICSFabric XICSFabric; struct ICPStateClass { DeviceClass parent_class; - void (*realize)(DeviceState *dev, Error **errp); - void (*pre_save)(ICPState *s); - int (*post_load)(ICPState *s, int version_id); + void (*realize)(ICPState *icp, Error **errp); + void (*pre_save)(ICPState *icp); + int (*post_load)(ICPState *icp, int version_id); void (*cpu_setup)(ICPState *icp, PowerPCCPU *cpu); void (*reset)(ICPState *icp); }; @@ -113,7 +113,7 @@ struct PnvICPState { struct ICSStateClass { DeviceClass parent_class; - void (*realize)(DeviceState *dev, Error **errp); + void (*realize)(ICSState *s, Error **errp); void (*pre_save)(ICSState *s); int (*post_load)(ICSState *s, int version_id); void (*reject)(ICSState *s, uint32_t irq); |