summary refs log tree commit diff stats
path: root/include/hw/qdev-core.h
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2016-07-21 23:58:37 +0200
committerEduardo Habkost <ehabkost@redhat.com>2016-07-27 11:25:06 -0300
commitb3443f43f45e06971d87c985bb0316c1e40259c9 (patch)
treeaa46a4cdab5f81f177e7d938e6bbbf9910b5c8bf /include/hw/qdev-core.h
parent78a3930685c3159c4b8f953bd9f9e7a28655d823 (diff)
downloadfocaccia-qemu-b3443f43f45e06971d87c985bb0316c1e40259c9.tar.gz
focaccia-qemu-b3443f43f45e06971d87c985bb0316c1e40259c9.zip
qdev: ignore GlobalProperty.errp for hotplugged devices
This patch ensures QEMU won't terminate while hotplugging a device if the
global property cannot be set and errp points to error_fatal or error_abort.

While here, it also fixes indentation of the typename argument.

Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'include/hw/qdev-core.h')
-rw-r--r--include/hw/qdev-core.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 1d1f8612a9..4b4b33bec8 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -261,7 +261,9 @@ struct PropertyInfo {
  * @used: Set to true if property was used when initializing a device.
  * @errp: Error destination, used like first argument of error_setg()
  *        in case property setting fails later. If @errp is NULL, we
- *        print warnings instead of ignoring errors silently.
+ *        print warnings instead of ignoring errors silently. For
+ *        hotplugged devices, errp is always ignored and warnings are
+ *        printed instead.
  */
 typedef struct GlobalProperty {
     const char *driver;