summary refs log tree commit diff stats
path: root/include/hw/qdev-core.h
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2017-03-01 11:50:26 +0000
committerStefan Hajnoczi <stefanha@redhat.com>2017-04-21 10:36:12 +0100
commitd72915c60bff51495529449750e051d01b03c62f (patch)
treec88c623920e0b81b24afd435adad57c4e65c39d2 /include/hw/qdev-core.h
parentab08aec45f67a776ea37cee0bf94a34abb84ad97 (diff)
downloadfocaccia-qemu-d72915c60bff51495529449750e051d01b03c62f.tar.gz
focaccia-qemu-d72915c60bff51495529449750e051d01b03c62f.zip
throttle: make throttle_config(throttle_get_config()) symmetric
Throttling has a weird property that throttle_get_config() does not
always return the same throttling settings that were given with
throttle_config().  In other words, the set and get functions aren't
symmetric.

If .max is 0 then the throttling code assigns a default value of .avg /
10 in throttle_config().  This is an implementation detail of the
throttling algorithm.  When throttle_get_config() is called the .max
value returned should still be 0.

Users are exposed to this quirk via "info block" or "query-block"
monitor commands.  This has caused confusion because it looks like a bug
when an unexpected value is reported.

This patch hides the .max value adjustment in throttle_get_config() and
updates test-throttle.c appropriately.

Reported-by: Nini Gu <ngu@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 20170301115026.22621-4-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/hw/qdev-core.h')
0 files changed, 0 insertions, 0 deletions