summary refs log tree commit diff stats
path: root/include/hw/virtio/vhost-user-base.h
diff options
context:
space:
mode:
authorDamien Bergamini <damien.bergamini@eviden.com>2025-09-01 15:14:23 +0000
committerMichael S. Tsirkin <mst@redhat.com>2025-10-05 09:01:08 -0400
commit2e54e5fda779a7ba45578884276dca62462f7a06 (patch)
tree0836dab7d7a727f1e5e78846ab7ac5f4df2fe162 /include/hw/virtio/vhost-user-base.h
parentd1193481dee63442fc41e47ca6ebc4cd34f1f69c (diff)
downloadfocaccia-qemu-2e54e5fda779a7ba45578884276dca62462f7a06.tar.gz
focaccia-qemu-2e54e5fda779a7ba45578884276dca62462f7a06.zip
pcie_sriov: Fix broken MMIO accesses from SR-IOV VFs
Starting with commit cab1398a60eb, SR-IOV VFs are realized as soon as
pcie_sriov_pf_init() is called.  Because pcie_sriov_pf_init() must be
called before pcie_sriov_pf_init_vf_bar(), the VF BARs types won't be
known when the VF realize function calls pcie_sriov_vf_register_bar().

This breaks the memory regions of the VFs (for instance with igbvf):

$ lspci
...
    Region 0: Memory at 281a00000 (64-bit, prefetchable) [virtual] [size=16K]
    Region 3: Memory at 281a20000 (64-bit, prefetchable) [virtual] [size=16K]

$ info mtree
...
address-space: pci_bridge_pci_mem
  0000000000000000-ffffffffffffffff (prio 0, i/o): pci_bridge_pci
    0000000081a00000-0000000081a03fff (prio 1, i/o): igbvf-mmio
    0000000081a20000-0000000081a23fff (prio 1, i/o): igbvf-msix

and causes MMIO accesses to fail:

    Invalid write at addr 0x281A01520, size 4, region '(null)', reason: rejected
    Invalid read at addr 0x281A00C40, size 4, region '(null)', reason: rejected

To fix this, VF BARs are now registered with pci_register_bar() which
has a type parameter and pcie_sriov_vf_register_bar() is removed.

Fixes: cab1398a60eb ("pcie_sriov: Reuse SR-IOV VF device instances")
Signed-off-by: Damien Bergamini <damien.bergamini@eviden.com>
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20250901151314.1038020-1-clement.mathieu--drif@eviden.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/virtio/vhost-user-base.h')
0 files changed, 0 insertions, 0 deletions