summary refs log tree commit diff stats
path: root/include/qemu-common.h
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2018-05-04 19:01:07 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2018-05-09 00:13:39 +0200
commit1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a (patch)
tree4f854522c6ac02bb10ebdb9ebb13c396a8b857ac /include/qemu-common.h
parent281b95231d79a7a7ecc93a51ebb8e68b1ce7f1e5 (diff)
downloadfocaccia-qemu-1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a.tar.gz
focaccia-qemu-1217d6ca2bf28c0febe1bd7d5b3fa912bbf6af2a.zip
qemu-options: Bail out on unsupported options instead of silently ignoring them
The dangling remainder of the -tdf option revealed a deficiency in our
option parsing: Options that have been declared, but are not supported
in the switch-case statement in vl.c and not handled in the OS-specifc
os_parse_cmd_args() functions are currently silently ignored. We should
rather tell the users that they specified something that we can not
handle, so let's print an error message and exit instead.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1525453270-23074-3-git-send-email-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/qemu-common.h')
-rw-r--r--include/qemu-common.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 8a4f63c9de..85f4749aef 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -137,7 +137,7 @@ char *qemu_find_file(int type, const char *name);
 /* OS specific functions */
 void os_setup_early_signal_handling(void);
 char *os_find_datadir(void);
-void os_parse_cmd_args(int index, const char *optarg);
+int os_parse_cmd_args(int index, const char *optarg);
 
 #include "qemu/module.h"