summary refs log tree commit diff stats
path: root/include/qemu/host-utils.h
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2017-09-04 09:59:01 +0200
committerGreg Kurz <groug@kaod.org>2017-09-05 17:56:58 +0200
commit32b6943699948f7adc35ada233fbd25daffad5e9 (patch)
treeea4c5b5dac814e685f78c620e9f547b68366860a /include/qemu/host-utils.h
parentaa5e85a10846636165592c5a46d797c100c68529 (diff)
downloadfocaccia-qemu-32b6943699948f7adc35ada233fbd25daffad5e9.tar.gz
focaccia-qemu-32b6943699948f7adc35ada233fbd25daffad5e9.zip
virtfs: error out gracefully when mandatory suboptions are missing
We internally convert -virtfs to -fsdev/-device. If the user doesn't
provide the path or security_model suboptions, and the fsdev backend
requires them, we hit an assertion when populating the internal -fsdev
option:

util/qemu-option.c:547: opt_set: Assertion `opt->str' failed.
Aborted (core dumped)

Let's test the suboption presence on the command line before trying
to set it in the internal -fsdev option, and let the backend code
error out gracefully (ie, like it already does when the user passes
-fsdev on the command line).

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'include/qemu/host-utils.h')
0 files changed, 0 insertions, 0 deletions