summary refs log tree commit diff stats
path: root/include/qemu/ratelimit.h
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2017-07-07 07:44:39 -0500
committerKevin Wolf <kwolf@redhat.com>2017-07-10 13:18:06 +0200
commitf3e4ce4af336f2ea306fa0f40ec1a5149864ca8c (patch)
tree2e862184064f654be327bb3a4aa12176ca978cdd /include/qemu/ratelimit.h
parentc616f16e0c9a2d0b2f13785d37ca0f18d54d571f (diff)
downloadfocaccia-qemu-f3e4ce4af336f2ea306fa0f40ec1a5149864ca8c.tar.gz
focaccia-qemu-f3e4ce4af336f2ea306fa0f40ec1a5149864ca8c.zip
blockjob: Track job ratelimits via bytes, not sectors
The user interface specifies job rate limits in bytes/second.
It's pointless to have our internal representation track things
in sectors/second, particularly since we want to move away from
sector-based interfaces.

Fix up a doc typo found while verifying that the ratelimit
code handles the scaling difference.

Repetition of expressions like 'n * BDRV_SECTOR_SIZE' will be
cleaned up later when functions are converted to iterate over
images by bytes rather than by sectors.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/qemu/ratelimit.h')
-rw-r--r--include/qemu/ratelimit.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h
index 8da1232574..8dece483f5 100644
--- a/include/qemu/ratelimit.h
+++ b/include/qemu/ratelimit.h
@@ -24,7 +24,8 @@ typedef struct {
 
 /** Calculate and return delay for next request in ns
  *
- * Record that we sent @p n data units. If we may send more data units
+ * Record that we sent @n data units (where @n matches the scale chosen
+ * during ratelimit_set_speed). If we may send more data units
  * in the current time slice, return 0 (i.e. no delay). Otherwise
  * return the amount of time (in ns) until the start of the next time
  * slice that will permit sending the next chunk of data.