summary refs log tree commit diff stats
path: root/include/semihosting/console.h
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2025-01-16 16:02:35 +0000
committerAlex Bennée <alex.bennee@linaro.org>2025-01-17 10:44:00 +0000
commit57792106562417ba03a1ac0f2a5afc3eb63c5d9e (patch)
treed9d23001375032efd81df9e85fa8db0e7a6bb2b5 /include/semihosting/console.h
parent847343cfbf80bd221f42595a0038a8d5e7ab7088 (diff)
downloadfocaccia-qemu-57792106562417ba03a1ac0f2a5afc3eb63c5d9e.tar.gz
focaccia-qemu-57792106562417ba03a1ac0f2a5afc3eb63c5d9e.zip
semihosting/console: Avoid including 'cpu.h'
The CPUState structure is declared in "hw/core/cpu.h",
the EXCP_HALTED definition in "exec/cpu-common.h".
Both headers are indirectly include by "cpu.h". In
order to remove "cpu.h" from "semihosting/console.h",
explicitly include them in console.c, otherwise we'd
get:

  ../semihosting/console.c:88:11: error: incomplete definition of type 'struct CPUState'
     88 |         cs->exception_index = EXCP_HALTED;
        |         ~~^
  ../semihosting/console.c:88:31: error: use of undeclared identifier 'EXCP_HALTED'
     88 |         cs->exception_index = EXCP_HALTED;
        |                               ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250103171037.11265-5-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20250116160306.1709518-7-alex.bennee@linaro.org>
Diffstat (limited to 'include/semihosting/console.h')
-rw-r--r--include/semihosting/console.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/include/semihosting/console.h b/include/semihosting/console.h
index bd78e5f03f..1c12e178ee 100644
--- a/include/semihosting/console.h
+++ b/include/semihosting/console.h
@@ -9,8 +9,6 @@
 #ifndef SEMIHOST_CONSOLE_H
 #define SEMIHOST_CONSOLE_H
 
-#include "cpu.h"
-
 /**
  * qemu_semihosting_console_read:
  * @cs: CPUState