diff options
| author | Peter Xu <peterx@redhat.com> | 2024-10-24 17:30:52 -0400 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-10-31 15:48:18 -0400 |
| commit | f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf (patch) | |
| tree | 6d93fec9312cea0071a58734b720dd46b22fdbfc /include | |
| parent | 64dcd2c9c627b88ec7d071e1b49f0180b467fc71 (diff) | |
| download | focaccia-qemu-f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf.tar.gz focaccia-qemu-f018eb62b2bb7618b0cb8a796ac4b76fd786ecaf.zip | |
migration: Drop migration_is_setup_or_active()
This helper is mostly the same as migration_is_running(), except that one has COLO reported as true, the other has CANCELLING reported as true. Per my past years experience on the state changes, none of them should matter. To make it slightly safer, report both COLO || CANCELLING to be true in migration_is_running(), then drop the other one. We kept the 1st only because the name is simpler, and clear enough. Reviewed-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20241024213056.1395400-5-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/migration/misc.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/migration/misc.h b/include/migration/misc.h index e8490e3af5..86ef160f19 100644 --- a/include/migration/misc.h +++ b/include/migration/misc.h @@ -52,11 +52,12 @@ void dump_vmstate_json_to_file(FILE *out_fp); /* migration/migration.c */ void migration_object_init(void); void migration_shutdown(void); + bool migration_is_idle(void); bool migration_is_active(void); bool migration_is_device(void); +bool migration_is_running(void); bool migration_thread_is_self(void); -bool migration_is_setup_or_active(void); typedef enum MigrationEventType { MIG_EVENT_PRECOPY_SETUP, @@ -95,7 +96,6 @@ void migration_add_notifier_mode(NotifierWithReturn *notify, MigrationNotifyFunc func, MigMode mode); void migration_remove_notifier(NotifierWithReturn *notify); -bool migration_is_running(void); void migration_file_set_error(int ret, Error *err); /* True if incoming migration entered POSTCOPY_INCOMING_DISCARD */ |