diff options
| author | Cao jin <caoj.fnst@cn.fujitsu.com> | 2016-09-12 14:34:56 +0800 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-09-13 19:09:43 +0200 |
| commit | c2cd627ddb13f62557aaf66305edb03cc3d9612d (patch) | |
| tree | 371e69422977c0c55d704199f10274c87a10562f /kvm-all.c | |
| parent | a952c18683bbfa67f6c508c7417001a0bd1b2b97 (diff) | |
| download | focaccia-qemu-c2cd627ddb13f62557aaf66305edb03cc3d9612d.tar.gz focaccia-qemu-c2cd627ddb13f62557aaf66305edb03cc3d9612d.zip | |
kvm-all: drop kvm_setup_guest_memory
kvm_setup_guest_memory only does "madvise to QEMU_MADV_DONTFORK" and is only called by ram_block_add, which actually is duplicate code. Bonus: add simple comment for kvm_has_sync_mmu to make life easier. Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> Message-Id: <1473662096-32598-1-git-send-email-caoj.fnst@cn.fujitsu.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'kvm-all.c')
| -rw-r--r-- | kvm-all.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/kvm-all.c b/kvm-all.c index ebf35b0c5b..8a4382eed8 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2148,6 +2148,7 @@ void kvm_device_access(int fd, int group, uint64_t attr, } } +/* Return 1 on success, 0 on failure */ int kvm_has_sync_mmu(void) { return kvm_check_extension(kvm_state, KVM_CAP_SYNC_MMU); @@ -2190,20 +2191,6 @@ int kvm_has_intx_set_mask(void) return kvm_state->intx_set_mask; } -void kvm_setup_guest_memory(void *start, size_t size) -{ - if (!kvm_has_sync_mmu()) { - int ret = qemu_madvise(start, size, QEMU_MADV_DONTFORK); - - if (ret) { - perror("qemu_madvise"); - fprintf(stderr, - "Need MADV_DONTFORK in absence of synchronous KVM MMU\n"); - exit(1); - } - } -} - #ifdef KVM_CAP_SET_GUEST_DEBUG struct kvm_sw_breakpoint *kvm_find_sw_breakpoint(CPUState *cpu, target_ulong pc) |