diff options
| author | Arun Menon <armenon@redhat.com> | 2025-09-18 20:53:29 +0530 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2025-10-03 09:48:02 -0400 |
| commit | 3f9d6e77b0471c844d5050cc71db0863eb4d1b64 (patch) | |
| tree | e6c698c5c3d35344f00113e1331e6e6ff24cd7cd /migration/colo.c | |
| parent | 8b6dad124ba757ba96a3b4456223e53632371bc8 (diff) | |
| download | focaccia-qemu-3f9d6e77b0471c844d5050cc71db0863eb4d1b64.tar.gz focaccia-qemu-3f9d6e77b0471c844d5050cc71db0863eb4d1b64.zip | |
migration: Update qemu_file_get_return_path() docs and remove dead checks
The documentation of qemu_file_get_return_path() states that it can return NULL on failure. However, a review of the current implementation reveals that it is guaranteed that it will always succeed and will never return NULL. As a result, the NULL checks post calling the function become redundant. This commit updates the documentation for the function and removes all NULL checks throughout the migration code. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Signed-off-by: Arun Menon <armenon@redhat.com> Tested-by: Fabiano Rosas <farosas@suse.de> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Link: https://lore.kernel.org/r/20250918-propagate_tpm_error-v14-12-36f11a6fb9d3@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'migration/colo.c')
| -rw-r--r-- | migration/colo.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/migration/colo.c b/migration/colo.c index ad50a3abc9..db783f6fa7 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -847,10 +847,6 @@ static void *colo_process_incoming_thread(void *opaque) failover_init_state(); mis->to_src_file = qemu_file_get_return_path(mis->from_src_file); - if (!mis->to_src_file) { - error_report("COLO incoming thread: Open QEMUFile to_src_file failed"); - goto out; - } /* * Note: the communication between Primary side and Secondary side * should be sequential, we set the fd to unblocked in migration incoming |