diff options
| author | Peter Xu <peterx@redhat.com> | 2024-02-02 18:28:50 +0800 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-02-05 14:42:10 +0800 |
| commit | d6556d174a6b9fc443f2320193f18e71eb67052a (patch) | |
| tree | d4dda39931d71af75d5afd9ce8262bf90536162b /migration/multifd.c | |
| parent | 3ab4441d97af59ea09ee015d68c4770704b2b34f (diff) | |
| download | focaccia-qemu-d6556d174a6b9fc443f2320193f18e71eb67052a.tar.gz focaccia-qemu-d6556d174a6b9fc443f2320193f18e71eb67052a.zip | |
migration/multifd: Change retval of multifd_queue_page()
Using int is an overkill when there're only two options. Change it to a boolean. Reviewed-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20240202102857.110210-17-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'migration/multifd.c')
| -rw-r--r-- | migration/multifd.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/migration/multifd.c b/migration/multifd.c index ba86f9dda5..12e587fda8 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -505,7 +505,8 @@ static int multifd_send_pages(void) return 1; } -int multifd_queue_page(RAMBlock *block, ram_addr_t offset) +/* Returns true if enqueue successful, false otherwise */ +bool multifd_queue_page(RAMBlock *block, ram_addr_t offset) { MultiFDPages_t *pages = multifd_send_state->pages; bool changed = false; @@ -519,21 +520,21 @@ int multifd_queue_page(RAMBlock *block, ram_addr_t offset) pages->num++; if (pages->num < pages->allocated) { - return 1; + return true; } } else { changed = true; } if (multifd_send_pages() < 0) { - return -1; + return false; } if (changed) { return multifd_queue_page(block, offset); } - return 1; + return true; } /* Multifd send side hit an error; remember it and prepare to quit */ |