summary refs log tree commit diff stats
path: root/migration/options.c
diff options
context:
space:
mode:
authorLeonardo Bras <leobras@redhat.com>2023-04-25 00:33:08 -0300
committerJuan Quintela <quintela@redhat.com>2023-04-27 10:18:25 +0200
commitb405dfff1ea3cf0530b628895b5a7a50dc8c6996 (patch)
treebd50d2ce01714d628935a1ebe1d098c5e872b155 /migration/options.c
parentc3f9aa8e488db330197c9217e38555f6772e8f07 (diff)
downloadfocaccia-qemu-b405dfff1ea3cf0530b628895b5a7a50dc8c6996.tar.gz
focaccia-qemu-b405dfff1ea3cf0530b628895b5a7a50dc8c6996.zip
migration: Disable postcopy + multifd migration
Since the introduction of multifd, it's possible to perform a multifd
migration and finish it using postcopy.

A bug introduced by yank (fixed on cfc3bcf373) was previously preventing
a successful use of this migration scenario, and now thing should be
working on most scenarios.

But since there is not enough testing/support nor any reported users for
this scenario, we should disable this combination before it may cause any
problems for users.

Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration/options.c')
-rw-r--r--migration/options.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/migration/options.c b/migration/options.c
index 8e8753d9be..dd97c99391 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -322,6 +322,11 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp)
             error_setg(errp, "Postcopy is not compatible with ignore-shared");
             return false;
         }
+
+        if (new_caps[MIGRATION_CAPABILITY_MULTIFD]) {
+            error_setg(errp, "Postcopy is not yet compatible with multifd");
+            return false;
+        }
     }
 
     if (new_caps[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT]) {