summary refs log tree commit diff stats
path: root/migration/ram.c
diff options
context:
space:
mode:
authorWei Yang <richardw.yang@linux.intel.com>2019-06-04 10:35:40 +0800
committerJuan Quintela <quintela@redhat.com>2019-07-15 15:39:02 +0200
commit77568ea7f845cefc5623f7d7fb75137b5e30b956 (patch)
treeb8f2f833d3a28a4c8da9ddcae801ccc23b1a03a1 /migration/ram.c
parent7c960d617ad4fee940c5bb4df96e91ae31f55d18 (diff)
downloadfocaccia-qemu-77568ea7f845cefc5623f7d7fb75137b5e30b956.tar.gz
focaccia-qemu-77568ea7f845cefc5623f7d7fb75137b5e30b956.zip
migration/multifd: sync packet_num after all thread are done
Notification from recv thread is not ordered, which means we may be
notified by one MultiFDRecvParams but adjust packet_num for another.

Move the adjustment after we are sure each recv thread are sync-ed.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20190604023540.26532-1-richardw.yang@linux.intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration/ram.c')
-rw-r--r--migration/ram.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/migration/ram.c b/migration/ram.c
index d3d72b6f4f..96c84f770a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1291,15 +1291,15 @@ static void multifd_recv_sync_main(void)
 
         trace_multifd_recv_sync_main_wait(p->id);
         qemu_sem_wait(&multifd_recv_state->sem_sync);
+    }
+    for (i = 0; i < migrate_multifd_channels(); i++) {
+        MultiFDRecvParams *p = &multifd_recv_state->params[i];
+
         qemu_mutex_lock(&p->mutex);
         if (multifd_recv_state->packet_num < p->packet_num) {
             multifd_recv_state->packet_num = p->packet_num;
         }
         qemu_mutex_unlock(&p->mutex);
-    }
-    for (i = 0; i < migrate_multifd_channels(); i++) {
-        MultiFDRecvParams *p = &multifd_recv_state->params[i];
-
         trace_multifd_recv_sync_main_signal(p->id);
         qemu_sem_post(&p->sem_sync);
     }