summary refs log tree commit diff stats
path: root/migration/savevm.c
diff options
context:
space:
mode:
authorAvihai Horon <avihaih@nvidia.com>2023-06-28 10:31:11 +0300
committerCédric Le Goater <clg@redhat.com>2023-06-30 06:02:51 +0200
commit808642a2f6407157f8cfb48ba6c2d28efd038d62 (patch)
treeee25880b0b05a512dbae45f0be645fdd5e6d2c0a /migration/savevm.c
parentc17408892319712c12357e5d1c6b305499c58c2a (diff)
downloadfocaccia-qemu-808642a2f6407157f8cfb48ba6c2d28efd038d62.tar.gz
focaccia-qemu-808642a2f6407157f8cfb48ba6c2d28efd038d62.zip
vfio/migration: Reset bytes_transferred properly
Currently, VFIO bytes_transferred is not reset properly:
1. bytes_transferred is not reset after a VM snapshot (so a migration
   following a snapshot will report incorrect value).
2. bytes_transferred is a single counter for all VFIO devices, however
   upon migration failure it is reset multiple times, by each VFIO
   device.

Fix it by introducing a new function vfio_reset_bytes_transferred() and
calling it during migration and snapshot start.

Remove existing bytes_transferred reset in VFIO migration state
notifier, which is not needed anymore.

Fixes: 3710586caa5d ("qapi: Add VFIO devices migration stats in Migration stats")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Diffstat (limited to 'migration/savevm.c')
-rw-r--r--migration/savevm.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/migration/savevm.c b/migration/savevm.c
index cdf4793924..95c2abf47c 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1622,6 +1622,7 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp)
     migrate_init(ms);
     memset(&mig_stats, 0, sizeof(mig_stats));
     memset(&compression_counters, 0, sizeof(compression_counters));
+    reset_vfio_bytes_transferred();
     ms->to_dst_file = f;
 
     qemu_mutex_unlock_iothread();