summary refs log tree commit diff stats
path: root/migration/vmstate-types.c
diff options
context:
space:
mode:
authorFabiano Rosas <farosas@suse.de>2025-01-09 15:52:45 -0300
committerFabiano Rosas <farosas@suse.de>2025-01-09 17:39:33 -0300
commit69d1f784569fdb950f2923c3b6d00d7c1b71acc1 (patch)
treeffa4a3edb803bf0c6b9d5a3a495f8809bbeaaa7d /migration/vmstate-types.c
parent2aead53d39b828f8d9d0769ffa3579dadd64d846 (diff)
downloadfocaccia-qemu-69d1f784569fdb950f2923c3b6d00d7c1b71acc1.tar.gz
focaccia-qemu-69d1f784569fdb950f2923c3b6d00d7c1b71acc1.zip
migration: Fix parsing of s390 stream
The parsing for the S390StorageAttributes section is currently leaving
an unconsumed token that is later interpreted by the generic code as
QEMU_VM_EOF, cutting the parsing short.

The migration will issue a STATTR_FLAG_DONE between iterations, which
the script consumes correctly, but there's a final STATTR_FLAG_EOS at
.save_complete that the script is ignoring. Since the EOS flag is a
u64 0x1ULL and the stream is big endian, on little endian hosts a byte
read from it will be 0x0, the same as QEMU_VM_EOF.

Fixes: 81c2c9dd5d ("tests/qtest/migration-test: Fix analyze-migration.py for s390x")
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20250109185249.23952-4-farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Diffstat (limited to 'migration/vmstate-types.c')
0 files changed, 0 insertions, 0 deletions