diff options
| author | Lorenz Brun <lorenz@brun.one> | 2024-03-15 15:58:31 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-03-26 14:24:06 +0100 |
| commit | 7c7a9f578e4fb1adff7ac8d9acaaaedb87474e76 (patch) | |
| tree | dcb3c683d41e8c209d6a7754850629ac25a91e1c /monitor/hmp-cmds-target.c | |
| parent | 9dab7bbb017d11b64c52239fa4e2f910a6a004f2 (diff) | |
| download | focaccia-qemu-7c7a9f578e4fb1adff7ac8d9acaaaedb87474e76.tar.gz focaccia-qemu-7c7a9f578e4fb1adff7ac8d9acaaaedb87474e76.zip | |
hw/scsi/scsi-generic: Fix io_timeout property not applying
The io_timeout property, introduced in c9b6609 (part of 6.0) is
silently overwritten by the hardcoded default value of 30 seconds
(DEFAULT_IO_TIMEOUT) in scsi_generic_realize because that function is
being called after the properties have already been applied.
The property definition already has a default value which is applied
correctly when no value is explicitly set, so we can just remove the
code which overrides the io_timeout completely.
This has been tested by stracing SG_IO operations with the io_timeout
property set and unset and now sets the timeout field in the ioctl
request to the proper value.
Fixes: c9b6609b69facad ("scsi: make io_timeout configurable")
Signed-off-by: Lorenz Brun <lorenz@brun.one>
Message-ID: <20240315145831.2531695-1-lorenz@brun.one>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'monitor/hmp-cmds-target.c')
0 files changed, 0 insertions, 0 deletions