summary refs log tree commit diff stats
path: root/monitor/misc.c
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2020-02-25 16:56:18 +0100
committerKevin Wolf <kwolf@redhat.com>2020-03-06 17:15:37 +0100
commiteeea1faa099f82328f5831cf252f8ce0a59a9287 (patch)
tree99a8ba12b38cd0e41ed227b5418e8ae9d0dec391 /monitor/misc.c
parent81311255f217859413c94f2cd9cebf2684bbda94 (diff)
downloadfocaccia-qemu-eeea1faa099f82328f5831cf252f8ce0a59a9287.tar.gz
focaccia-qemu-eeea1faa099f82328f5831cf252f8ce0a59a9287.zip
block: Fix leak in bdrv_create_file_fallback()
@options is leaked by the first two return statements in this function.

Note that blk_new_open() takes the reference to @options even on
failure, so all we need to do to fix the leak is to move the QDict
allocation down to where we actually need it.

Reported-by: Coverity (CID 1419884)
Fixes: fd17146cd93d1704cd96d7c2757b325fc7aac6fd
       ("block: Generic file creation fallback")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200225155618.133412-1-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'monitor/misc.c')
0 files changed, 0 insertions, 0 deletions