diff options
| author | Peter Xu <peterx@redhat.com> | 2024-12-06 17:47:55 -0500 |
|---|---|---|
| committer | Fabiano Rosas <farosas@suse.de> | 2025-01-09 17:38:32 -0300 |
| commit | baab4473dba2b85adf3c0622b92bc209f7a8dec0 (patch) | |
| tree | 7a5ee2dc6b8605f3f2280735fd53f4c9b41ccb29 /monitor | |
| parent | 1aa81c3098f0270905deff516d455604fcbfaab5 (diff) | |
| download | focaccia-qemu-baab4473dba2b85adf3c0622b92bc209f7a8dec0.tar.gz focaccia-qemu-baab4473dba2b85adf3c0622b92bc209f7a8dec0.zip | |
migration/multifd: Document the reason to sync for save_setup()
It's not straightforward to see why src QEMU needs to sync multifd during setup() phase. After all, there's no page queued at that point. For old QEMUs, there's a solid reason: EOS requires it to work. While it's clueless on the new QEMUs which do not take EOS message as sync requests. One will figure that out only when this is conditionally removed. In fact, the author did try it out. Logically we could still avoid doing this on new machine types, however that needs a separate compat field and that can be an overkill in some trivial overhead in setup() phase. Let's instead document it completely, to avoid someone else tries this again and do the debug one more time, or anyone confused on why this ever existed. Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Fabiano Rosas <farosas@suse.de> Message-Id: <20241206224755.1108686-8-peterx@redhat.com> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Diffstat (limited to 'monitor')
0 files changed, 0 insertions, 0 deletions