diff options
| author | Zhang Chen <zhangchen.fnst@cn.fujitsu.com> | 2017-04-18 10:20:20 +0800 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2017-04-25 19:17:25 +0800 |
| commit | 0fc8aec7de64f2bf83a274a2a38b938ce03425d2 (patch) | |
| tree | 652f11daded2dce41da0826bb338df18d532eb9a /net/colo-compare.c | |
| parent | 184d4d42033d5c111276e4eef9ea273c2e114d18 (diff) | |
| download | focaccia-qemu-0fc8aec7de64f2bf83a274a2a38b938ce03425d2.tar.gz focaccia-qemu-0fc8aec7de64f2bf83a274a2a38b938ce03425d2.zip | |
COLO-compare: Optimize tcp compare trace event
Optimize two trace events as one, adjust print format make it easy to read. rename trace_colo_compare_pkt_info_src/dst to trace_colo_compare_tcp_info. Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net/colo-compare.c')
| -rw-r--r-- | net/colo-compare.c | 29 |
1 files changed, 17 insertions, 12 deletions
diff --git a/net/colo-compare.c b/net/colo-compare.c index 4ab80b1cbb..03ddebe5d3 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -264,18 +264,23 @@ static int colo_packet_compare_tcp(Packet *spkt, Packet *ppkt) res = -1; } - if (res != 0 && trace_event_get_state(TRACE_COLO_COMPARE_MISCOMPARE)) { - trace_colo_compare_pkt_info_src(inet_ntoa(ppkt->ip->ip_src), - ntohl(stcp->th_seq), - ntohl(stcp->th_ack), - res, stcp->th_flags, - spkt->size); - - trace_colo_compare_pkt_info_dst(inet_ntoa(ppkt->ip->ip_dst), - ntohl(ptcp->th_seq), - ntohl(ptcp->th_ack), - res, ptcp->th_flags, - ppkt->size); + if (res && trace_event_get_state(TRACE_COLO_COMPARE_MISCOMPARE)) { + char ip_src[20], ip_dst[20]; + + strcpy(ip_src, inet_ntoa(ppkt->ip->ip_src)); + strcpy(ip_dst, inet_ntoa(ppkt->ip->ip_dst)); + + trace_colo_compare_tcp_info(ip_src, + ip_dst, + ntohl(ptcp->th_seq), + ntohl(stcp->th_seq), + ntohl(ptcp->th_ack), + ntohl(stcp->th_ack), + res, + ptcp->th_flags, + stcp->th_flags, + ppkt->size, + spkt->size); qemu_hexdump((char *)ppkt->data, stderr, "colo-compare ppkt", ppkt->size); |