diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2024-10-23 09:50:56 +0100 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2024-10-28 14:37:25 +0800 |
| commit | 1f37280b37dbf85f36748f359a9f8802c8fe7ccd (patch) | |
| tree | 94a4191340a7bb7a6134e6ba909121e0a0920e98 /net | |
| parent | cea8ac78545a83e1f01c94d89d6f5a3f6b5c05d2 (diff) | |
| download | focaccia-qemu-1f37280b37dbf85f36748f359a9f8802c8fe7ccd.tar.gz focaccia-qemu-1f37280b37dbf85f36748f359a9f8802c8fe7ccd.zip | |
net: fix build when libbpf is disabled, but libxdp is enabled
The net/af-xdp.c code is enabled when the libxdp library is present, however, it also has direct API calls to bpf_xdp_query_id & bpf_xdp_detach which are provided by the libbpf library. As a result if building with --disable-libbpf, but libxdp gets auto-detected, we'll fail to link QEMU /usr/bin/ld: libcommon.a.p/net_af-xdp.c.o: undefined reference to symbol 'bpf_xdp_query_id@@LIBBPF_0.7.0' There are two bugs here * Since we have direct libbpf API calls, when building net/af-xdp.c, we must tell meson that libbpf is a dependancy, so that we directly link to it, rather than relying on indirect linkage. * When must skip probing for libxdp at all, when libbpf is not found, raising an error if --enable-libxdp was given explicitly. Fixes: cb039ef3d9e3112da01e1ecd9b136ac9809ef733 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/meson.build | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/meson.build b/net/meson.build index e0cd71470e..bb97b4dcbe 100644 --- a/net/meson.build +++ b/net/meson.build @@ -39,7 +39,7 @@ if have_netmap system_ss.add(files('netmap.c')) endif -system_ss.add(when: libxdp, if_true: files('af-xdp.c')) +system_ss.add(when: [libxdp, libbpf], if_true: files('af-xdp.c')) if have_vhost_net_user system_ss.add(when: 'CONFIG_VIRTIO_NET', if_true: files('vhost-user.c'), if_false: files('vhost-user-stub.c')) |