summary refs log tree commit diff stats
path: root/numa.c
diff options
context:
space:
mode:
authorLaurent Vivier <lvivier@redhat.com>2017-03-21 11:25:42 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2017-03-22 11:32:42 +1100
commit55641213fc81cdfc3bcd56c9e9991faa119201b2 (patch)
treef48f41e82bdafedf094dfc0d03f55cbde2fb9c33 /numa.c
parent55a19ad8b2d0797e3a8fe90ab99a9bb713824059 (diff)
downloadfocaccia-qemu-55641213fc81cdfc3bcd56c9e9991faa119201b2.tar.gz
focaccia-qemu-55641213fc81cdfc3bcd56c9e9991faa119201b2.zip
numa,spapr: align default numa node memory size to 256MB
Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node
memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE).

But when "-numa" option is provided without "mem" parameter,
the memory is equally divided between nodes, but 8MB aligned.
This can be not valid for pseries.

In that case we can have:
$ ./ppc64-softmmu/qemu-system-ppc64 -m 4G -numa node -numa node -numa node
qemu-system-ppc64: Node 0 memory size 0x55000000 is not aligned to 256 MiB

With this patch, we have:
(qemu) info numa
3 nodes
node 0 cpus: 0
node 0 size: 1280 MB
node 1 cpus:
node 1 size: 1280 MB
node 2 cpus:
node 2 size: 1536 MB

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'numa.c')
-rw-r--r--numa.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/numa.c b/numa.c
index e01cb547a2..6fc2393ddd 100644
--- a/numa.c
+++ b/numa.c
@@ -338,12 +338,12 @@ void parse_numa_opts(MachineClass *mc)
         if (i == nb_numa_nodes) {
             uint64_t usedmem = 0;
 
-            /* On Linux, each node's border has to be 8MB aligned,
-             * the final node gets the rest.
+            /* Align each node according to the alignment
+             * requirements of the machine class
              */
             for (i = 0; i < nb_numa_nodes - 1; i++) {
                 numa_info[i].node_mem = (ram_size / nb_numa_nodes) &
-                                        ~((1 << 23UL) - 1);
+                                        ~((1 << mc->numa_mem_align_shift) - 1);
                 usedmem += numa_info[i].node_mem;
             }
             numa_info[i].node_mem = ram_size - usedmem;