diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2021-11-16 11:14:31 +0100 |
|---|---|---|
| committer | Hanna Reitz <hreitz@redhat.com> | 2021-11-16 11:30:29 +0100 |
| commit | 5dbd0ce115c7720268e653fe928bb6a0c1314a80 (patch) | |
| tree | 5818409971aec6480d1950649893e9c876159fd2 /python/qemu/machine/qtest.py | |
| parent | c9d4e42a8febe4db22eed8463087b38c3c74fd4c (diff) | |
| download | focaccia-qemu-5dbd0ce115c7720268e653fe928bb6a0c1314a80.tar.gz focaccia-qemu-5dbd0ce115c7720268e653fe928bb6a0c1314a80.zip | |
file-posix: Fix alignment after reopen changing O_DIRECT
At the end of a reopen, we already call bdrv_refresh_limits(), which
should update bs->request_alignment according to the new file
descriptor. However, raw_probe_alignment() relies on s->needs_alignment
and just uses 1 if it isn't set. We neglected to update this field, so
starting with cache=writeback and then reopening with cache=none means
that we get an incorrect bs->request_alignment == 1 and unaligned
requests fail instead of being automatically aligned.
Fix this by recalculating s->needs_alignment in raw_refresh_limits()
before calling raw_probe_alignment().
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20211104113109.56336-1-kwolf@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20211115145409.176785-13-kwolf@redhat.com>
[hreitz: Fix iotest 142 for block sizes greater than 512 by operating on
a file with a size of 1 MB]
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20211116101431.105252-1-hreitz@redhat.com>
Diffstat (limited to 'python/qemu/machine/qtest.py')
0 files changed, 0 insertions, 0 deletions