diff options
| author | Daniel Henrique Barboza <danielhb413@gmail.com> | 2022-06-21 14:34:31 -0300 |
|---|---|---|
| committer | Daniel Henrique Barboza <danielhb413@gmail.com> | 2022-07-06 10:22:37 -0300 |
| commit | 792e8bb629c6c11e99b092d10790a6d027d7f2d2 (patch) | |
| tree | 2224d968dc4feba873cf3b9144d87f1e5610a626 /python/qemu/utils/qemu_ga_client.py | |
| parent | 8625164a3866064da0e37aabef7cab40311fd929 (diff) | |
| download | focaccia-qemu-792e8bb629c6c11e99b092d10790a6d027d7f2d2.tar.gz focaccia-qemu-792e8bb629c6c11e99b092d10790a6d027d7f2d2.zip | |
ppc/pnv: assign pnv-phb-root-port chassis/slot earlier
It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. In fact this is not needed. There is nothing sophisticated being done with the PHB object retrieved during root_port_realize() for both PHB3 and PHB4. We're retrieving a PHB reference just to access phb->chip_id and phb->phb_id and use them to define the chassis/slot of the root port. phb->phb_id is already being passed to pnv_phb_attach_root_port() via the 'index' parameter. Let's also add a 'chip_id' parameter to this function and assign chassis and slot right there. This will spare us from the hassle of accessing the PHB object inside realize(). Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com> Message-Id: <20220621173436.165912-4-danielhb413@gmail.com>
Diffstat (limited to 'python/qemu/utils/qemu_ga_client.py')
0 files changed, 0 insertions, 0 deletions