summary refs log tree commit diff stats
path: root/python
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2020-07-06 15:39:45 -0500
committerKevin Wolf <kwolf@redhat.com>2020-07-14 15:18:59 +0200
commit4e2f4418784da09cb106264340241856cd2846df (patch)
treef76b995a6d8248b4a8be9b337b802b12d88bca01 /python
parentffa244c84a1a30dff69ecc80b0137a2b6d428ecb (diff)
downloadfocaccia-qemu-4e2f4418784da09cb106264340241856cd2846df.tar.gz
focaccia-qemu-4e2f4418784da09cb106264340241856cd2846df.zip
qemu-img: Flush stdout before before potential stderr messages
During 'qemu-img create ... 2>&1', if --quiet is not in force, we can
end up with buffered I/O in stdout that was produced before failure,
but which appears in output after failure.  This is confusing; the fix
is to flush stdout prior to attempting anything that might produce an
error message.  Several iotests demonstrate the resulting ordering
change now that the merged outputs now reflect chronology.  (An even
better fix would be to avoid printf from within block.c altogether,
but that's much more invasive...)

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-2-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'python')
0 files changed, 0 insertions, 0 deletions