summary refs log tree commit diff stats
path: root/python
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2021-05-27 17:16:50 -0400
committerJohn Snow <jsnow@redhat.com>2021-06-01 16:21:21 -0400
commita0eae17a59fcbcdc96af2ea2a6767d758ff4a916 (patch)
tree685f4db7a458c8d9390a0828268e54bd6468fea7 /python
parent63c33f3c286efe4c6474b53ae97915c9d1a6923a (diff)
downloadfocaccia-qemu-a0eae17a59fcbcdc96af2ea2a6767d758ff4a916.tar.gz
focaccia-qemu-a0eae17a59fcbcdc96af2ea2a6767d758ff4a916.zip
python/machine: disable warning for Popen in _launch()
We handle this resource rather meticulously in
shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in
_do_shutdown().

Quiet this pylint warning here.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-7-jsnow@redhat.com
Message-id: 20210517184808.3562549-7-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python')
-rw-r--r--python/qemu/machine.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index c66bc6a9c6..5d72c4ca36 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -405,6 +405,9 @@ class QEMUMachine:
                   self._args)
         )
         LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
+
+        # Cleaning up of this subprocess is guaranteed by _do_shutdown.
+        # pylint: disable=consider-using-with
         self._popen = subprocess.Popen(self._qemu_full_args,
                                        stdin=subprocess.DEVNULL,
                                        stdout=self._qemu_log_file,