diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-07-27 16:12:10 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2020-07-27 16:12:10 +0100 |
| commit | ca05a240d4fa2ce880c630058b635482d3d472f8 (patch) | |
| tree | 3aa3b205ddd483e1d1f224c8c969b2255945804b /python | |
| parent | 4bf7c0cb09a59314aca261291e3a20a24c7dd3b3 (diff) | |
| download | focaccia-qemu-ca05a240d4fa2ce880c630058b635482d3d472f8.tar.gz focaccia-qemu-ca05a240d4fa2ce880c630058b635482d3d472f8.zip | |
hw/misc/aspeed_sdmc: Fix incorrect memory size
The SDRAM Memory Controller has a 32-bit address bus, thus
supports up to 4 GiB of DRAM. There is a signed to unsigned
conversion error with the AST2600 maximum memory size:
(uint64_t)(2048 << 20) = (uint64_t)(-2147483648)
= 0xffffffff40000000
= 16 EiB - 2 GiB
Fix by using the IEC suffixes which are usually safer, and add
an assertion check to verify the memory is valid. This would have
caught this bug:
$ qemu-system-arm -M ast2600-evb
qemu-system-arm: hw/misc/aspeed_sdmc.c:258: aspeed_sdmc_realize: Assertion `asc->max_ram_size < 4 * GiB' failed.
Aborted (core dumped)
Fixes: 1550d72679 ("aspeed/sdmc: Add AST2600 support")
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'python')
0 files changed, 0 insertions, 0 deletions