summary refs log tree commit diff stats
path: root/qapi/qapi-clone-visitor.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2017-11-13 09:24:24 -0600
committerEric Blake <eblake@redhat.com>2017-11-17 08:02:45 -0600
commitcb6b1a3fc30c52ffd94ed0b69ca5991b19651724 (patch)
tree8c38d9416a14bb411219670a00520622a44992ba /qapi/qapi-clone-visitor.c
parent08ace1d75372b57c5ab56aea02c71cdda4b58fdf (diff)
downloadfocaccia-qemu-cb6b1a3fc30c52ffd94ed0b69ca5991b19651724.tar.gz
focaccia-qemu-cb6b1a3fc30c52ffd94ed0b69ca5991b19651724.zip
nbd/client: Use error_prepend() correctly
When using error prepend(), it is necessary to end with a space
in the format string; otherwise, messages come out incorrectly,
such as when connecting to a socket that hangs up immediately:

can't open device nbd://localhost:10809/: Failed to read dataUnexpected end-of-file before all bytes were read

Originally botched in commit e44ed99d, then several more instances
added in the meantime.

Pre-existing and not fixed here: we are inconsistent on capitalization;
some of our messages start with lower case, and others start with upper,
although the use of error_prepend() is much nicer to read when all
fragments consistently start with lower.

CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20171113152424.25381-1-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi/qapi-clone-visitor.c')
0 files changed, 0 insertions, 0 deletions