summary refs log tree commit diff stats
path: root/qapi/string-output-visitor.c
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2022-03-21 16:16:05 -0400
committerHanna Reitz <hreitz@redhat.com>2022-03-22 10:14:27 +0100
commit569131d585efb9a2fe9188c0edd12d22619afaca (patch)
tree4824b8369f94c59cf86ef4d3cec92c9543dcb6eb /qapi/string-output-visitor.c
parent2882ccf86a9bc7ea9ae23dce2bad91c8d3e7e135 (diff)
downloadfocaccia-qemu-569131d585efb9a2fe9188c0edd12d22619afaca.tar.gz
focaccia-qemu-569131d585efb9a2fe9188c0edd12d22619afaca.zip
iotests: fortify compare_images() against crashes
Fortify compare_images() to be more discerning about the status codes it
receives. If qemu_img() returns an exit code that implies it didn't
actually perform the comparison, treat that as an exceptional
circumstance and force the caller to be aware of the peril.

If a negative test is desired (perhaps to test how qemu_img compare
behaves on malformed images, for instance), it is still possible to
catch the exception in the test and deal with that circumstance
manually.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220321201618.903471-6-jsnow@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Diffstat (limited to 'qapi/string-output-visitor.c')
0 files changed, 0 insertions, 0 deletions