diff options
| author | Eduardo Habkost <ehabkost@redhat.com> | 2016-06-06 12:53:54 -0300 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2016-06-07 15:00:02 +0100 |
| commit | d5aebef884cabf197d51d2066a5beee8d0c721d4 (patch) | |
| tree | b4320b8e891dcfb10bca1467cbee07d6772707e3 /qapi/string-output-visitor.c | |
| parent | 0601d6a4112a5b0333d2348aa2c3465cc0075ec6 (diff) | |
| download | focaccia-qemu-d5aebef884cabf197d51d2066a5beee8d0c721d4.tar.gz focaccia-qemu-d5aebef884cabf197d51d2066a5beee8d0c721d4.zip | |
docker: Don't use eval trick on Makefile
The eval trick for defining DOCKER_SRC_COPY doesn't do anything useful, as DOCKER_SRC_COPY is immediately expanded just after it is defined, and CUR_TIME is already defined using ":=". Simply define it using ":=" so it is evaluated only once. The eval trick was also triggering an weird error on Travis builds: qemu/tests/docker/Makefile.include:34: *** unterminated variable reference. Stop. The issue is not easily reproducible (maybe it's a bug in some versions of Make), but it is avoided if removing the eval trick. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'qapi/string-output-visitor.c')
0 files changed, 0 insertions, 0 deletions