summary refs log tree commit diff stats
path: root/qemu-bridge-helper.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2019-06-04 13:52:21 +0200
committerJason Wang <jasowang@redhat.com>2019-07-02 10:21:06 +0800
commit436e3530763cb1e9c65d9575a9809f29ca3ef7e5 (patch)
tree5061f5cba8b1c9a323e23f7f25fc9c1fb09fa61a /qemu-bridge-helper.c
parente9bbc8bd8a7a02b8a7d8e90cfef56b49e739f64c (diff)
downloadfocaccia-qemu-436e3530763cb1e9c65d9575a9809f29ca3ef7e5.tar.gz
focaccia-qemu-436e3530763cb1e9c65d9575a9809f29ca3ef7e5.zip
qemu-bridge-helper: Document known shortcomings
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'qemu-bridge-helper.c')
-rw-r--r--qemu-bridge-helper.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index f9940deefd..95624bc300 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -10,7 +10,17 @@
  *
  * This work is licensed under the terms of the GNU GPL, version 2.  See
  * the COPYING file in the top-level directory.
- *
+ */
+
+/*
+ * Known shortcomings:
+ * - There is no manual page
+ * - The syntax of the ACL file is not documented anywhere
+ * - parse_acl_file() doesn't report fopen() failure properly, fails
+ *   to check ferror() after fgets() failure, arbitrarily truncates
+ *   long lines, handles whitespace inconsistently, error messages
+ *   don't point to the offending file and line, errors in included
+ *   files are reported, but otherwise ignored, ...
  */
 
 #include "qemu/osdep.h"