diff options
| author | Stefan Reiter <s.reiter@proxmox.com> | 2020-10-21 16:44:56 +0200 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2020-10-26 06:55:37 -0500 |
| commit | ed7b70c27b5c11ff4800e608d301cd7a36b81c5e (patch) | |
| tree | 4785a7ba48aefa565a9a2585fe96c2457db1b517 /qemu-img.c | |
| parent | 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430 (diff) | |
| download | focaccia-qemu-ed7b70c27b5c11ff4800e608d301cd7a36b81c5e.tar.gz focaccia-qemu-ed7b70c27b5c11ff4800e608d301cd7a36b81c5e.zip | |
migration/block-dirty-bitmap: fix larger granularity bitmaps
sectors_per_chunk is a 64 bit integer, but the calculation is done in 32 bits, leading to an overflow for coarse bitmap granularities. If that results in the value 0, it leads to a hang where no progress is made but send_bitmap_bits is constantly called with nr_sectors being 0. Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> Message-Id: <20201021144456.1072-1-s.reiter@proxmox.com> Fixes: b35ebdf07 migration: add postcopy migration of dirty bitmaps Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Eric Blake <eblake@redhat.com> [eblake: Use correct type for 8ULL, use () to avoid overflow] Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'qemu-img.c')
0 files changed, 0 insertions, 0 deletions