diff options
| author | Stefan Weil <sw@weilnetz.de> | 2014-03-05 22:23:00 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-03-13 14:42:24 +0100 |
| commit | f988388025c230ef3293cc0c3820cb40e03adfbf (patch) | |
| tree | 0937333939b9627ee21cdb7385bc1152a70acbfe /qemu-io.c | |
| parent | 9562f69cfdc55c7c1625bb88df1637fed182e68b (diff) | |
| download | focaccia-qemu-f988388025c230ef3293cc0c3820cb40e03adfbf.tar.gz focaccia-qemu-f988388025c230ef3293cc0c3820cb40e03adfbf.zip | |
qemu-io: Fix warnings from static code analysis
Smatch complains about several global symbols which should be local. Add the missing 'static' attributes and move the 'extern' declaration of variable qemuio_misalign to qemu-io.h. This variable also changes the type from 'int' to 'bool' which better fits documents its use. Signed-off-by: Stefan Weil <sw@weilnetz.de> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'qemu-io.c')
| -rw-r--r-- | qemu-io.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/qemu-io.c b/qemu-io.c index fc3860884c..2d119c28a6 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -24,10 +24,9 @@ #define CMD_NOFILE_OK 0x01 -char *progname; +static char *progname; -BlockDriverState *qemuio_bs; -extern int qemuio_misalign; +static BlockDriverState *qemuio_bs; /* qemu-io commands passed using -c */ static int ncmdline; @@ -408,7 +407,7 @@ int main(int argc, char **argv) readonly = 1; break; case 'm': - qemuio_misalign = 1; + qemuio_misalign = true; break; case 'g': growable = 1; |