diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2015-01-15 12:06:16 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2015-01-22 11:18:41 +0100 |
| commit | 51a090991449c7d3c6d428eda18b4f30a36e2c1b (patch) | |
| tree | aaf96f3e56f74c952ddde71bd5eb411e9e669b52 /qemu-timer.c | |
| parent | fe4831b1e7e7007ae15ae0470a06898660ab3877 (diff) | |
| download | focaccia-qemu-51a090991449c7d3c6d428eda18b4f30a36e2c1b.tar.gz focaccia-qemu-51a090991449c7d3c6d428eda18b4f30a36e2c1b.zip | |
spice: fix coverity reported defect in display code
Report:
1. Condition surface, taking false branch
406 if (surface && ssd->surface &&
407 surface_width(surface) == pixman_image_get_width(ssd->surface) &&
408 surface_height(surface) == pixman_image_get_height(ssd->surface)) {
409 /* no-resize fast path: just swap backing store */
...
10. alias_transfer: Assigning: ssd->ds = surface.
440 ssd->ds = surface;
11. var_deref_op: Dereferencing null pointer ssd->ds.
CID 1264334 (#1 of 1): Dereference after null check (FORWARD_NULL)
441 ssd->surface = pixman_image_ref(ssd->ds->image);
Fix:
Move code block dereferencing ssd->ds into the already existing
if (ssd->ds) { ... } block.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'qemu-timer.c')
0 files changed, 0 insertions, 0 deletions