summary refs log tree commit diff stats
path: root/qga/commands-posix.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2019-12-04 10:36:18 +0100
committerCornelia Huck <cohuck@redhat.com>2019-12-14 10:25:50 +0100
commit3d508334dd2c5f920a1b5221124b6633c3bf8e38 (patch)
tree4f9e9207151b0ddfe075076841b0f775ee101739 /qga/commands-posix.c
parente893baee70149896d1e43e341da4d6c614037d5d (diff)
downloadfocaccia-qemu-3d508334dd2c5f920a1b5221124b6633c3bf8e38.tar.gz
focaccia-qemu-3d508334dd2c5f920a1b5221124b6633c3bf8e38.zip
s390x/event-facility: Fix realize() error API violations
sclp_events_bus_realize() dereferences @errp when
object_property_set_bool() fails.  That's wrong; see the big comment
in error.h.  Introduced in commit f6102c329c "s390/sclp: rework sclp
event facility initialization + device realization".

No caller actually passes null.

Fix anyway: splice in a local Error *err, and error_propagate().

Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-12-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'qga/commands-posix.c')
0 files changed, 0 insertions, 0 deletions