diff options
| author | Florian Lugou <florian.lugou@provenrun.com> | 2025-06-05 12:12:54 +0200 |
|---|---|---|
| committer | Alistair Francis <alistair.francis@wdc.com> | 2025-07-04 21:09:48 +1000 |
| commit | 61240e3a06dc622d249b530557d5ce03c5854592 (patch) | |
| tree | 2e750296e880c4e8619e714c87d417c02acb6dcb /rust/qemu-api-macros/src/bits.rs | |
| parent | 2b027e73eefab0f9d3a0048564d1b653ba1d7703 (diff) | |
| download | focaccia-qemu-61240e3a06dc622d249b530557d5ce03c5854592.tar.gz focaccia-qemu-61240e3a06dc622d249b530557d5ce03c5854592.zip | |
hw/char: sifive_uart: Avoid infinite delay of async xmit function
The current handler for TXFIFO writes schedules an async callback to pop characters from the queue. When software writes to TXFIFO faster than the async callback delay (100ns), the timer may be pushed back while the previous character has not be dequeued yet. This happens in particular when using -icount with small shift values. This is especially worrysome when software repetitively issues amoor.w instructions (as suggested by SiFive specification) and the FIFO is full, leading to the callback being infinitly pushed back. This commit fixes the issue by never pushing back the timer, only updating it if it is not already active. Signed-off-by: Florian Lugou <florian.lugou@provenrun.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-ID: <20250605101255.797162-1-florian.lugou@provenrun.com> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'rust/qemu-api-macros/src/bits.rs')
0 files changed, 0 insertions, 0 deletions