summary refs log tree commit diff stats
path: root/rust/qemu-api-macros
diff options
context:
space:
mode:
authorPeter Xu <peterx@redhat.com>2025-01-14 18:07:31 -0500
committerFabiano Rosas <farosas@suse.de>2025-01-29 11:56:40 -0300
commit013c6e1f423c8c3b25e244eaabfbd38d865c6841 (patch)
treec428221729138926d5a16b8161b9a87e1641fd61 /rust/qemu-api-macros
parent45c3d6cfbbe1336176a719a9487289ecd951fb99 (diff)
downloadfocaccia-qemu-013c6e1f423c8c3b25e244eaabfbd38d865c6841.tar.gz
focaccia-qemu-013c6e1f423c8c3b25e244eaabfbd38d865c6841.zip
migration: Remove postcopy implications in should_send_vmdesc()
should_send_vmdesc() has a hack inside (which was not reflected in the
function name) in that it tries to detect global postcopy state and that
will affect the value to be returned.

It's easier to keep the helper simple by only check the suppress-vmdesc
property.  Then:

  - On the sender side of its usage, there's already in_postcopy variable
    that we can use: postcopy doesn't send vmdesc at all, so directly skip
    everything for postcopy.

  - On the recv side, when reaching vmdesc processing it must be precopy
    code already, hence that hack check never used to work anyway.

No functional change intended, except a trivial side effect that QEMU
source will start to avoid running some JSON helper in postcopy path, but
that would only reduce the postcopy blackout window a bit, rather than any
other bad side effect.

Signed-off-by: Peter Xu <peterx@redhat.com>
Tested-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Juraj Marcin <jmarcin@redhat.com>
Link: https://lore.kernel.org/r/20250114230746.3268797-2-peterx@redhat.com
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Diffstat (limited to 'rust/qemu-api-macros')
0 files changed, 0 insertions, 0 deletions