summary refs log tree commit diff stats
path: root/rust/qemu-api/src/sysbus.rs
diff options
context:
space:
mode:
authorClément Léger <cleger@rivosinc.com>2025-01-10 13:54:32 +0100
committerAlistair Francis <alistair.francis@wdc.com>2025-01-19 09:44:35 +1000
commit507957eb2acfd321646c98bc853d6c8bafe628d2 (patch)
tree363348f7dbe92f438ab4fdabfc7730c4f2984ea9 /rust/qemu-api/src/sysbus.rs
parentfdb7bce43f9008d83e1edfd260a8165119b61ca5 (diff)
downloadfocaccia-qemu-507957eb2acfd321646c98bc853d6c8bafe628d2.tar.gz
focaccia-qemu-507957eb2acfd321646c98bc853d6c8bafe628d2.zip
target/riscv: Fix henvcfg potentially containing stale bits
With the current implementation, if we had the following scenario:
- Set bit x in menvcfg
- Set bit x in henvcfg
- Clear bit x in menvcfg
then, the internal variable env->henvcfg would still contain bit x due
to both a wrong menvcfg mask used in write_henvcfg() as well as a
missing update of henvcfg upon menvcfg update.
This can lead to some wrong interpretation of the context. In order to
update henvcfg upon menvcfg writing, call write_henvcfg() after writing
menvcfg. Clearing henvcfg upon writing the new value is also needed in
write_henvcfg() as well as clearing henvcfg upper part when writing it
with write_henvcfgh().

Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20250110125441.3208676-2-cleger@rivosinc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'rust/qemu-api/src/sysbus.rs')
0 files changed, 0 insertions, 0 deletions