summary refs log tree commit diff stats
path: root/scripts/archive-source.sh
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2017-09-28 10:59:58 +0800
committerStefan Hajnoczi <stefanha@redhat.com>2017-10-03 14:36:19 -0400
commitf708a5e71cba0d784e307334c07ade5f56f827ab (patch)
tree8e4786bfdf43921d8ff54aa6cf279769612d184d /scripts/archive-source.sh
parent5b3ac23fee97fc1a79ad2bb1cf3a1ce518d27905 (diff)
downloadfocaccia-qemu-f708a5e71cba0d784e307334c07ade5f56f827ab.tar.gz
focaccia-qemu-f708a5e71cba0d784e307334c07ade5f56f827ab.zip
aio: fix assert when remove poll during destroy
After iothread is enabled internally inside QEMU with GMainContext, we
may encounter this warning when destroying the iothread:

(qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll:
 assertion '!SOURCE_DESTROYED (source)' failed

The problem is that g_source_remove_poll() does not allow to remove one
source from array if the source is detached from its owner
context. (peterx: which IMHO does not make much sense)

Fix it on QEMU side by avoid calling g_source_remove_poll() if we know
the object is during destruction, and we won't leak anything after all
since the array will be gone soon cleanly even with that fd.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-id: 20170928025958.1420-6-peterx@redhat.com
[peterx: write the commit message]
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'scripts/archive-source.sh')
0 files changed, 0 insertions, 0 deletions